fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 07:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

radv: do not expose buffer features for depth/stencil formats

Browse source 
The Vulkan spec got clarified recently and it's invalid (hw can support
it though). Fixes new CTS dEQP-VK.api.buffer.invalid_buffer_features.*.

Cc: 21.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13701>
(cherry picked from commit ca7c748f45)
This commit is contained in:
Samuel Pitoiset 2021-11-08 08:50:14 +01:00 • committed by Eric Engestrom
parent b5ebe0ec36
commit b726997029
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -382,7 +382,7 @@
"description": "radv: do not expose buffer features for depth/stencil formats", "description": "radv: do not expose buffer features for depth/stencil formats",
"nominated": true, "nominated": true,
"nomination_type": 0, "nomination_type": 0,
"resolution": 0, "resolution": 1,
"main_sha": null, "main_sha": null,
"because_sha": null "because_sha": null
}, },

5
src/amd/vulkan/radv_formats.c
View file

@ -868,6 +868,11 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical
tiled |= VK_FORMAT_FEATURE_2_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR; tiled |= VK_FORMAT_FEATURE_2_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR;
} }
/* It's invalid to expose buffer features with depth/stencil formats. */
if (vk_format_is_depth_or_stencil(format)) {
buffer = 0;
}
out_properties->linearTilingFeatures = linear; out_properties->linearTilingFeatures = linear;
out_properties->optimalTilingFeatures = tiled; out_properties->optimalTilingFeatures = tiled;
out_properties->bufferFeatures = buffer; out_properties->bufferFeatures = buffer;