From b6d828576e1d561ad49c01f19c1cb5ba39e3832a Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Tue, 21 Nov 2023 09:29:41 +0100 Subject: [PATCH] zink: Always fill external_only in zink_query_dmabuf_modifiers Fix piglit.spec@ext_image_dma_buf_import@ext_image_dma_buf_import-modifiers randomly skipping some tests as external_only content was never initialized. Cc: mesa-stable Reviewed-by: default avatarMike Blumenkrantz Signed-off-by: Mary Guillemard Part-of: --- src/gallium/drivers/zink/zink_screen.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/zink/zink_screen.c b/src/gallium/drivers/zink/zink_screen.c index aa92c3d2be8..5a6d17cb4fa 100644 --- a/src/gallium/drivers/zink/zink_screen.c +++ b/src/gallium/drivers/zink/zink_screen.c @@ -2457,8 +2457,12 @@ zink_query_dmabuf_modifiers(struct pipe_screen *pscreen, enum pipe_format format { struct zink_screen *screen = zink_screen(pscreen); *count = screen->modifier_props[format].drmFormatModifierCount; - for (int i = 0; i < MIN2(max, *count); i++) + for (int i = 0; i < MIN2(max, *count); i++) { + if (external_only) + external_only[i] = 0; + modifiers[i] = screen->modifier_props[format].pDrmFormatModifierProperties[i].drmFormatModifier; + } } static bool