diff --git a/.pick_status.json b/.pick_status.json index f3d665f1e68..29398e986f4 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -850,7 +850,7 @@ "description": "zink: Fully initialize VkBufferViewCreateInfo for hashing", "nominated": false, "nomination_type": null, - "resolution": 4, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/gallium/drivers/zink/zink_context.c b/src/gallium/drivers/zink/zink_context.c index 826ae3ce5fd..58fbc220624 100644 --- a/src/gallium/drivers/zink/zink_context.c +++ b/src/gallium/drivers/zink/zink_context.c @@ -626,7 +626,10 @@ static VkBufferViewCreateInfo create_bvci(struct zink_context *ctx, struct zink_resource *res, enum pipe_format format, uint32_t offset, uint32_t range) { struct zink_screen *screen = zink_screen(ctx->base.screen); - VkBufferViewCreateInfo bvci = {0}; + VkBufferViewCreateInfo bvci; + // Zero whole struct (including alignment holes), so hash_bufferview + // does not access potentially uninitialized data. + memset(&bvci, 0, sizeof(bvci)); bvci.sType = VK_STRUCTURE_TYPE_BUFFER_VIEW_CREATE_INFO; bvci.pNext = NULL; bvci.buffer = res->obj->buffer;