fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-28 08:10:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

gallium/noop: don't unref buffers passed to set_vertex_buffers to fix crashes

Browse source 
this code is invalid after the refcounting rework

Fixes: b3133e250e - gallium: add pipe_context::resource_release to eliminate buffer refcounting

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
(cherry picked from commit 7d22e4c7ba)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38432>
This commit is contained in:
Marek Olšák 2025-10-05 22:58:39 -04:00 • committed by Dylan Baker
parent 76d66b72db
commit b5a4245193
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -714,7 +714,7 @@
"description": "gallium/noop: don't unref buffers passed to set_vertex_buffers to fix crashes",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "b3133e250e1c40496d98c4ba52386b7ae423d194",
"notes": null

6
src/gallium/auxiliary/driver_noop/noop_state.c
View file

@ -185,12 +185,6 @@ static void noop_set_vertex_buffers(struct pipe_context *ctx,
unsigned count,
const struct pipe_vertex_buffer *buffers)
{
for (unsigned i = 0; i < count; i++) {
if (!buffers[i].is_user_buffer) {
struct pipe_resource *buf = buffers[i].buffer.resource;
pipe_resource_reference(&buf, NULL);
}
}
}
static void *noop_create_vertex_elements(struct pipe_context *ctx,