fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 06:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

r600/sfn: Take source uses into account when switching channels

Browse source 
When we switch the channels by re-creating vec4 values we have to
take into account that the source values may be used in an ALU op,
and with that we have to take read-port limitations into account.

Fixes: 18a8d148d8
    r600/sfn: Cleanup copy-prop into vec4 source values

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24519>
(cherry picked from commit 807c0d6bb7)
This commit is contained in:
Gert Wollny 2023-08-06 20:42:07 +02:00 • committed by Dylan Baker
parent 77e4c75f8b
commit b5330ce1d4
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -10564,7 +10564,7 @@
"description": "r600/sfn: Take source uses into account when switching channels",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "18a8d148d862d4a0f5b83f4385f00cf8a4a71b6d",
"notes": null

6
src/gallium/drivers/r600/sfn/sfn_optimizer.cpp
View file

@ -551,6 +551,12 @@ CopyPropFwdVisitor::propagate_to(RegisterVec4& value, Instr *instr)
allowed_mask &= alu->allowed_dest_chan_mask();
}
for (auto u : src->uses()) {
auto alu = u->as_alu();
if (alu)
allowed_mask &= alu->allowed_src_chan_mask();
}
if (!allowed_mask)
return;