draw: only fill in / compare the part of the translate key we're using.

It's quite a big struct & we examine it a lot (too much).  Reduce
the impact of this by just looking at the active part where possible.
This commit is contained in:
Keith Whitwell 2008-05-08 22:13:21 +01:00
parent fec1d215f6
commit b514f5f3ba
3 changed files with 11 additions and 10 deletions

View file

@ -49,6 +49,7 @@ void draw_pt_emit_prepare( struct pt_emit *emit,
const struct vertex_info *vinfo;
unsigned dst_offset;
struct translate_key hw_key;
unsigned keysize;
unsigned i;
boolean ok;
@ -58,12 +59,10 @@ void draw_pt_emit_prepare( struct pt_emit *emit,
return;
}
memset(&hw_key, 0, sizeof(hw_key));
/* Must do this after set_primitive() above:
*/
vinfo = draw->render->get_vertex_info(draw->render);
keysize = 2*4 + vinfo->num_attribs * sizeof(hw_key.element[0]);
/* Translate from pipeline vertices to hw vertices.
*/
@ -122,8 +121,9 @@ void draw_pt_emit_prepare( struct pt_emit *emit,
hw_key.output_stride = vinfo->size * 4;
if (!emit->translate ||
memcmp(&emit->translate->key, &hw_key, sizeof(hw_key)) != 0)
memcmp(&emit->translate->key, &hw_key, keysize) != 0)
{
memset((char *)&hw_key + keysize, 0, sizeof(hw_key) - keysize);
emit->translate = translate_cache_find(emit->cache, &hw_key);
}
}

View file

@ -62,10 +62,11 @@ void draw_pt_fetch_prepare( struct pt_fetch *fetch,
unsigned i, nr = 0;
unsigned dst_offset = 0;
struct translate_key key;
unsigned keysize;
fetch->vertex_size = vertex_size;
memset(&key, 0, sizeof(key));
keysize = (2*4 +
(draw->pt.nr_vertex_elements + 1) * sizeof(key.element[0]));
/* Always emit/leave space for a vertex header.
*
@ -110,8 +111,9 @@ void draw_pt_fetch_prepare( struct pt_fetch *fetch,
if (!fetch->translate ||
memcmp(&fetch->translate->key, &key, sizeof(key)) != 0)
memcmp(&fetch->translate->key, &key, keysize) != 0)
{
memset((char *)&key + keysize, 0, sizeof(key) - keysize);
fetch->translate = translate_cache_find(fetch->cache, &key);
{

View file

@ -47,10 +47,9 @@
struct translate_element
{
enum pipe_format input_format;
unsigned input_buffer;
unsigned input_offset;
enum pipe_format output_format;
unsigned input_buffer;
unsigned input_offset; /* can't really reduce the size of these */
unsigned output_offset;
};