fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 02:38:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

anv: reemit push constants on pipeline changes

Browse source 
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 02294961ee ("anv: stop using a binding table entry for gl_NumWorkgroups")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12058
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31799>
This commit is contained in:
Lionel Landwerlin 2024-10-23 11:40:52 +03:00 • committed by Marge Bot
parent 7d9449c873
commit b4ae8cf381
1 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/intel/vulkan/genX_cmd_compute.c
View file

@ -145,15 +145,23 @@ genX(cmd_buffer_flush_compute_state)(struct anv_cmd_buffer *cmd_buffer)
genX(cmd_buffer_ensure_cfe_state)(cmd_buffer, prog_data->base.total_scratch);
#endif
#if GFX_VERx10 == 120
/* Normally we should not require any dirtying here, but for some reason
* on Gfx12.0, when running tests in parallel we see failures in the
* dEQP-VK.memory_model.* tests. This is likely a HW issue with push
/* Changing the pipeline affects the push constants layout (different
* amount of cross/per thread allocations). The allocation is also
* bounded to just the amount consummed by the pipeline (see
* anv_cmd_buffer_cs_push_constants). So we force the reallocation for
* every pipeline change.
*
* On Gfx12.0 we're also seeing failures in the dEQP-VK.memory_model.*
* tests when run in parallel. This is likely a HW issue with push
* constants & context save/restore.
*
* TODO: optimize this on Gfx12.5+ where the shader is not using per
* thread allocations and is also pulling the data using SEND messages.
* We should be able to limit reallocations only the data actually
* changes.
*/
cmd_buffer->state.push_constants_dirty |= VK_SHADER_STAGE_COMPUTE_BIT;
comp_state->base.push_constants_data_dirty = true;
#endif
}
cmd_buffer->state.descriptors_dirty |=