fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 06:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glsl: Semantically check the RHS of `&&' even when short-circuiting.

Browse source 
We just do the AST-to-HIR processing, and only push the instructions
if needed in the constant true case.

Fixes glslparsertest/glsl2/logic-01.frag

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Chad Versace <chad.versace@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
(cherry picked from commit 7ec0c97896)
This commit is contained in:
Eric Anholt 2011-04-09 10:27:02 -10:00 • committed by Ian Romanick
parent 7609af4228
commit b47825e626
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/glsl/ast_to_hir.cpp
View file

@ -1105,14 +1105,17 @@ ast_expression::hir(exec_list *instructions,
break;
case ast_logic_and: {
exec_list rhs_instructions;
op[0] = get_scalar_boolean_operand(instructions, state, this, 0,
"LHS", &error_emitted);
op[1] = get_scalar_boolean_operand(&rhs_instructions, state, this, 1,
"RHS", &error_emitted);
ir_constant *op0_const = op[0]->constant_expression_value();
if (op0_const) {
if (op0_const->value.b[0]) {
result = get_scalar_boolean_operand(instructions, state, this, 1,
"RHS", &error_emitted);
instructions->append_list(&rhs_instructions);
result = op[1];
} else {
result = op0_const;
}
@ -1126,10 +1129,7 @@ ast_expression::hir(exec_list *instructions,
ir_if *const stmt = new(ctx) ir_if(op[0]);
instructions->push_tail(stmt);
op[1] = get_scalar_boolean_operand(&stmt->then_instructions,
state, this, 1,
"RHS", &error_emitted);
stmt->then_instructions.append_list(&rhs_instructions);
ir_dereference *const then_deref = new(ctx) ir_dereference_variable(tmp);
ir_assignment *const then_assign =
new(ctx) ir_assignment(then_deref, op[1], NULL);