From b2b6e56583f2b8a192ec2f4e1ed4ee3a6558fd0b Mon Sep 17 00:00:00 2001 From: Antonio Ospite Date: Thu, 24 Jul 2025 14:54:06 +0200 Subject: [PATCH] etnaviv: fix returning _Bool instead of pointer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When building for C23 the compiler warns about returning a boolean when a different type is expected instead. Change the code to return NULL instead of false, fixing the following error: ----------------------------------------------------------------------- ../src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c: In function ‘perfmon_allocate’: ../src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c:109:14: error: incompatible types when returning type ‘_Bool’ but ‘struct etna_acc_query *’ was expected 109 | return false; | ^~~~~ ../src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c:112:14: error: incompatible types when returning type ‘_Bool’ but ‘struct etna_acc_query *’ was expected 112 | return false; | ^~~~~ ----------------------------------------------------------------------- Reviewed-by: Faith Ekstrand Part-of: --- src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c b/src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c index c3091b63026..dd51737840c 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c +++ b/src/gallium/drivers/etnaviv/etnaviv_query_acc_perfmon.c @@ -106,10 +106,10 @@ perfmon_allocate(struct etna_context *ctx, unsigned query_type) cfg = etna_pm_query_config(query_type); if (!cfg) - return false; + return NULL; if (!etna_pm_cfg_supported(ctx->screen->perfmon, cfg)) - return false; + return NULL; pq = CALLOC_STRUCT(etna_pm_query); if (!pq)