fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

crocus: Support offset query for multi-planar planes

Browse source 
Multi-planar planes can be imported from VA-API or V4L2. In this case we
would currently report wrong values for `gbm_bo_get_offset()`.

This does not fix any know visible bug, as crocus hardware usually does
not support muliti-planar planes in the display engine - in which case
the wrong values would make Mutter glitch. Lets report correct values
regardless.

While on it, also use the helper function for counting planes.

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28225>
This commit is contained in:
Robert Mader 2024-03-15 14:49:11 +01:00 • committed by Marge Bot
parent 899fcaf237
commit b2719a73c1
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/gallium/drivers/crocus/crocus_resource.c
View file

@ -38,6 +38,7 @@
#include "util/u_cpu_detect.h"
#include "util/u_inlines.h"
#include "util/format/u_format.h"
#include "util/u_resource.h"
#include "util/u_threaded_context.h"
#include "util/u_transfer.h"
#include "util/u_transfer_helper.h"
@ -913,7 +914,8 @@ crocus_resource_get_param(struct pipe_screen *pscreen,
uint64_t *value)
{
struct crocus_screen *screen = (struct crocus_screen *)pscreen;
struct crocus_resource *res = (struct crocus_resource *)resource;
struct crocus_resource *res =
(struct crocus_resource *)util_resource_at_index(resource, plane);
/* Modifiers with compression are not supported. */
assert(!res->mod_info ||
@ -927,18 +929,14 @@ crocus_resource_get_param(struct pipe_screen *pscreen,
crocus_resource_disable_aux_on_first_query(resource, handle_usage);
switch (param) {
case PIPE_RESOURCE_PARAM_NPLANES: {
unsigned count = 0;
for (struct pipe_resource *cur = resource; cur; cur = cur->next)
count++;
*value = count;
case PIPE_RESOURCE_PARAM_NPLANES:
*value = util_resource_num(resource);
return true;
}
case PIPE_RESOURCE_PARAM_STRIDE:
*value = res->surf.row_pitch_B;
return true;
case PIPE_RESOURCE_PARAM_OFFSET:
*value = 0;
*value = res->offset;
return true;
case PIPE_RESOURCE_PARAM_MODIFIER:
*value = res->mod_info ? res->mod_info->modifier :