From b204153106f6495f00b92dc7a26fd2bab3368f2c Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Thu, 22 May 2025 09:13:04 +0300 Subject: [PATCH] anv: add a comment about Wa_14016820455 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Lionel Landwerlin Reviewed-by: Tapani Pälli Part-of: --- src/intel/vulkan/genX_gfx_state.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/genX_gfx_state.c b/src/intel/vulkan/genX_gfx_state.c index 0d0be9afc17..31a3864a345 100644 --- a/src/intel/vulkan/genX_gfx_state.c +++ b/src/intel/vulkan/genX_gfx_state.c @@ -2972,8 +2972,13 @@ genX(cmd_buffer_flush_gfx_hw_state)(struct anv_cmd_buffer *cmd_buffer) * because of another one is changing. */ - /* Reproduce the programming done on Windows drivers. - * Fixes flickering issues with multiple workloads. + /* Reprogram SF_CLIP & CC_STATE together. This reproduces the programming + * done on Windows drivers. Fixes flickering issues with multiple + * workloads. + * + * Since blorp disables 3DSTATE_CLIP::ClipEnable and dirties CC_STATE, this + * also takes care of Wa_14016820455 which requires SF_CLIP to be + * reprogrammed whenever 3DSTATE_CLIP::ClipEnable is enabled. */ if (BITSET_TEST(hw_state->dirty, ANV_GFX_STATE_VIEWPORT_SF_CLIP) || BITSET_TEST(hw_state->dirty, ANV_GFX_STATE_VIEWPORT_CC_PTR)) {