From b17df365292a18a7d2d9c8ce8622cbf382aba3de Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Wed, 4 Feb 2026 14:45:27 -0800 Subject: [PATCH] iris: Drop sprite coord checks from SBE_SWIZ setup The "override with a constant" handling appears to take precedence over the "override with point sprite coordinates" handling. Because we were overriding undefined inputs to <0, 0, 0, 1>, we needed to avoid this for sprite coordinates, as they aren't written by a previous stage, but shouldn't be overridden to zero. Now that we've dropped that in the previous patch, there's no need to special case sprite coordinates any longer. Reviewed-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/iris/iris_state.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c index 020b77dd2e8..c467e525cb2 100644 --- a/src/gallium/drivers/iris/iris_state.c +++ b/src/gallium/drivers/iris/iris_state.c @@ -4824,8 +4824,7 @@ static void iris_emit_sbe_swiz(struct iris_batch *batch, const struct iris_context *ice, const struct intel_vue_map *vue_map, - unsigned urb_read_offset, - unsigned sprite_coord_enables) + unsigned urb_read_offset) { struct GENX(SF_OUTPUT_ATTRIBUTE_DETAIL) attr_overrides[16] = {}; const struct iris_fs_data *fs_data = @@ -4844,9 +4843,6 @@ iris_emit_sbe_swiz(struct iris_batch *batch, &attr_overrides[input_index]; int slot = vue_map->varying_to_slot[fs_attr]; - if (sprite_coord_enables & (1 << input_index)) - continue; - /* If there was only a back color written but not front, use back * as the color instead of undefined. */ @@ -4972,8 +4968,7 @@ iris_emit_sbe(struct iris_batch *batch, const struct iris_context *ice) } } - iris_emit_sbe_swiz(batch, ice, last_vue_map, urb_read_offset, - sprite_coord_overrides); + iris_emit_sbe_swiz(batch, ice, last_vue_map, urb_read_offset); } /* ------------------------------------------------------------------- */