fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-17 16:50:34 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco: Fix parameter stack size calculation

Browse source 
This only accounted for 1/32 (or 1/64) of the actual parameter size. In
some cases this meant that some threads were smashing other threads'
stacks.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39455>
(cherry picked from commit 15328a5ef3)
This commit is contained in:
Natalie Vock 2026-01-22 13:25:32 +01:00 • committed by Eric Engestrom
parent b12d9282c9
commit b055af7ceb
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3454,7 +3454,7 @@
"description": "aco: Fix parameter stack size calculation",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

2
src/amd/compiler/instruction_selection/aco_isel_helpers.cpp
View file

@ -672,7 +672,7 @@ build_end_with_regs(isel_context* ctx, std::vector<Operand>& regs)
Instruction*
add_startpgm(struct isel_context* ctx, bool is_callee)
{
ctx->program->scratch_arg_size += ctx->callee_info.scratch_param_size;
ctx->program->scratch_arg_size += ctx->callee_info.scratch_param_size * ctx->program->wave_size;
unsigned def_count = 0;
for (unsigned i = 0; i < ctx->args->arg_count; i++) {