From af895692b3b52599e456f14e08a3beaa32b5a4c8 Mon Sep 17 00:00:00 2001 From: Asahi Lina Date: Wed, 14 Jun 2023 17:09:15 +0900 Subject: [PATCH] asahi: Revert "Advertise ARB_texture_barrier" This reverts commit 9e67d3f23780a818b9fc764105f39c6d595c6530. We do not, in fact, implement texture barriers. Texture barriers are supposed to allow non-overlapping rendering feedback loops. We cannot support that at non-tile boundaries when texture compression is enabled without some kind of downgrade path or other special handling. Fixes Emacs corruption on X/Glamor. Signed-off-by: Asahi Lina Part-of: --- docs/features.txt | 2 +- src/gallium/drivers/asahi/agx_pipe.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 4ead41fc502..c393bd1e700 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -220,7 +220,7 @@ GL 4.5, GLSL 4.50 -- all DONE: freedreno/a6xx, nvc0, r600, radeonsi, llvmpipe, v GL_ARB_direct_state_access DONE (all drivers) GL_ARB_get_texture_sub_image DONE (all drivers) GL_ARB_shader_texture_image_samples DONE (freedreno/a3xx+, nv50, crocus/gen7+) - GL_ARB_texture_barrier DONE (freedreno, nv50, vc4, lima, asahi, crocus) + GL_ARB_texture_barrier DONE (freedreno, nv50, vc4, lima, crocus) GL_KHR_context_flush_control DONE (all - but needs GLX/EGL extension to be useful) GL_KHR_robustness DONE (freedreno) GL_EXT_shader_integer_mix DONE (all drivers that support GLSL) diff --git a/src/gallium/drivers/asahi/agx_pipe.c b/src/gallium/drivers/asahi/agx_pipe.c index 76800c17c6e..635f4616785 100644 --- a/src/gallium/drivers/asahi/agx_pipe.c +++ b/src/gallium/drivers/asahi/agx_pipe.c @@ -1471,7 +1471,6 @@ agx_get_param(struct pipe_screen *pscreen, enum pipe_cap param) case PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT: case PIPE_CAP_SHADER_PACK_HALF_FLOAT: case PIPE_CAP_FS_FINE_DERIVATIVE: - case PIPE_CAP_TEXTURE_BARRIER: return 1; /* We could support ARB_clip_control by toggling the clip control bit for