fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 04:38:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Elucidate thread group split field

Browse source 
Last unknown field in the XML :-)

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11074>
This commit is contained in:
Alyssa Rosenzweig 2021-05-20 19:25:00 -04:00 • committed by Marge Bot
parent 71f069bd7a
commit ae93796cc0
3 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gallium/drivers/panfrost/pan_context.c
View file

@ -553,7 +553,7 @@ panfrost_direct_draw(struct panfrost_batch *batch,
cfg.workgroups_x_shift = 0;
cfg.workgroups_y_shift = 0;
cfg.workgroups_z_shift = 32;
cfg.unknown_shift = 2;
cfg.thread_group_split = MALI_SPLIT_MIN_EFFICIENT;
}
}

4
src/panfrost/lib/midgard.xml
View file

@ -626,7 +626,9 @@
<field name="Workgroups X shift" size="6" start="1:10" type="uint"/>
<field name="Workgroups Y shift" size="6" start="1:16" type="uint"/>
<field name="Workgroups Z shift" size="6" start="1:22" type="uint"/>
<field name="Unknown shift" size="4" start="1:28" type="uint"/>
<field name="Thread group split" size="4" start="1:28" type="uint" prefix="MALI_SPLIT">
<value name="Min efficient" value="2"/>
</field>
</struct>
<enum name="Point Size Array Format">

8
src/panfrost/lib/pan_invocation.c
View file

@ -98,9 +98,11 @@ panfrost_pack_work_groups_compute(
if (quirk_graphics && (num_z <= 1))
cfg.workgroups_z_shift = 32;
/* Quirk: for graphics, >= 2. For compute, 2 without barriers
* but equal to workgroups_x_shift with barriers */
/* For graphics, set to the minimum efficient value. For
* compute, must equal the workgroup X shift for barriers to
* function correctly */
cfg.unknown_shift = quirk_graphics ? 2 : cfg.workgroups_x_shift;
cfg.thread_group_split = quirk_graphics ?
MALI_SPLIT_MIN_EFFICIENT : cfg.workgroups_x_shift;
}
}