fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 05:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

draw: Don't assert if indices point outside vertex buffer.

Browse source 
This is valid input, and asserting here does causes the test suites that
verify this to crash.

Also, the assert was wrongly accepting the case

  max_index == vert_info->count

which, IIUC, is the first vertex outside the buffer. Assuming the
vert_info->count is precise (which often is not the case).
This commit is contained in:
José Fonseca 2010-08-22 02:26:09 +01:00
parent ce9a6e6a7d
commit ae34a6393e
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gallium/auxiliary/draw/draw_pipe.c
View file

@ -238,7 +238,7 @@ void draw_pipeline_run( struct draw_context *draw,
const unsigned count = prim_info->primitive_lengths[i];
#if DEBUG
/* make sure none of the element indexes go outside the vertex buffer */
/* Warn if one of the element indexes go outside the vertex buffer */
{
unsigned max_index = 0x0, i;
/* find the largest element index */
@ -247,7 +247,12 @@ void draw_pipeline_run( struct draw_context *draw,
if (index > max_index)
max_index = index;
}
assert(max_index <= vert_info->count);
if (max_index >= vert_info->count) {
debug_printf("%s: max_index (%u) outside vertex buffer (%u)\n",
__FUNCTION__,
max_index,
vert_info->count);
}
}
#endif