fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 15:48:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

venus: Dedupe pipeline handle creation

Browse source 
Refactor the code into new function vn_create_pipeline_handles().

Signed-off-by: Chad Versace <chadversary@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Reviewed-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17847>
This commit is contained in:
Chad Versace 2022-08-12 14:56:31 -07:00 • committed by Marge Bot
parent c66622de3a
commit ad8c8e366a
1 changed files with 34 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

69
src/virtio/vulkan/vn_pipeline.c
View file

@ -246,6 +246,35 @@ vn_MergePipelineCaches(VkDevice device,
/* pipeline commands */ /* pipeline commands */
static bool
vn_create_pipeline_handles(struct vn_device *dev,
uint32_t pipeline_count,
VkPipeline *pipeline_handles,
const VkAllocationCallbacks *alloc)
{
for (uint32_t i = 0; i < pipeline_count; i++) {
struct vn_pipeline *pipeline =
vk_zalloc(alloc, sizeof(*pipeline), VN_DEFAULT_ALIGN,
VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
if (!pipeline) {
for (uint32_t j = 0; j < i; j++) {
vk_free(alloc, pipeline_handles[j]);
}
memset(pipeline_handles, 0,
pipeline_count * sizeof(pipeline_handles[0]));
return false;
}
vn_object_base_init(&pipeline->base, VK_OBJECT_TYPE_PIPELINE,
&dev->base);
pipeline_handles[i] = vn_pipeline_to_handle(pipeline);
}
return true;
}
/** Fixes for a single VkGraphicsPipelineCreateInfo. */ /** Fixes for a single VkGraphicsPipelineCreateInfo. */
struct vn_graphics_pipeline_create_info_fix { struct vn_graphics_pipeline_create_info_fix {
bool ignore_tessellation_state; bool ignore_tessellation_state;
@ -611,24 +640,9 @@ vn_CreateGraphicsPipelines(VkDevice device,
if (!pCreateInfos) if (!pCreateInfos)
return vn_error(dev->instance, VK_ERROR_OUT_OF_HOST_MEMORY); return vn_error(dev->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
for (uint32_t i = 0; i < createInfoCount; i++) { if (!vn_create_pipeline_handles(dev, createInfoCount, pPipelines, alloc)) {
struct vn_pipeline *pipeline = vk_free(alloc, fixes);
vk_zalloc(alloc, sizeof(*pipeline), VN_DEFAULT_ALIGN, return vn_error(dev->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
if (!pipeline) {
for (uint32_t j = 0; j < i; j++)
vk_free(alloc, vn_pipeline_from_handle(pPipelines[j]));
vk_free(alloc, fixes);
memset(pPipelines, 0, sizeof(*pPipelines) * createInfoCount);
return vn_error(dev->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
}
vn_object_base_init(&pipeline->base, VK_OBJECT_TYPE_PIPELINE,
&dev->base);
VkPipeline pipeline_handle = vn_pipeline_to_handle(pipeline);
pPipelines[i] = pipeline_handle;
} }
vn_async_vkCreateGraphicsPipelines(dev->instance, device, pipelineCache, vn_async_vkCreateGraphicsPipelines(dev->instance, device, pipelineCache,
@ -653,23 +667,8 @@ vn_CreateComputePipelines(VkDevice device,
const VkAllocationCallbacks *alloc = const VkAllocationCallbacks *alloc =
pAllocator ? pAllocator : &dev->base.base.alloc; pAllocator ? pAllocator : &dev->base.base.alloc;
for (uint32_t i = 0; i < createInfoCount; i++) { if (!vn_create_pipeline_handles(dev, createInfoCount, pPipelines, alloc))
struct vn_pipeline *pipeline = return vn_error(dev->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
vk_zalloc(alloc, sizeof(*pipeline), VN_DEFAULT_ALIGN,
VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
if (!pipeline) {
for (uint32_t j = 0; j < i; j++)
vk_free(alloc, vn_pipeline_from_handle(pPipelines[j]));
memset(pPipelines, 0, sizeof(*pPipelines) * createInfoCount);
return vn_error(dev->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
}
vn_object_base_init(&pipeline->base, VK_OBJECT_TYPE_PIPELINE,
&dev->base);
VkPipeline pipeline_handle = vn_pipeline_to_handle(pipeline);
pPipelines[i] = pipeline_handle;
}
vn_async_vkCreateComputePipelines(dev->instance, device, pipelineCache, vn_async_vkCreateComputePipelines(dev->instance, device, pipelineCache,
createInfoCount, pCreateInfos, NULL, createInfoCount, pCreateInfos, NULL,