fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-08 19:20:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

v3dv: fix leak during device initialization

Browse source 
Fixes: 188f1c6cbe ('v3dv: rewrite device identification')

Reviewed-by: Karmjit Mahil <karmjit.mahil@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31703>
This commit is contained in:
Iago Toral Quiroga 2024-10-17 08:46:22 +02:00 • committed by Marge Bot
parent e4301621a2
commit ad111aed29
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/broadcom/vulkan/v3dv_device.c
View file

@ -1443,6 +1443,8 @@ fail:
static bool
try_device(const char *path, int *fd, const char *target)
{
drmVersionPtr version = NULL;
*fd = open(path, O_RDWR | O_CLOEXEC);
if (*fd < 0) {
fprintf(stderr, "Opening %s failed: %s\n", path, strerror(errno));
@ -1452,7 +1454,7 @@ try_device(const char *path, int *fd, const char *target)
if (!target)
return true;
drmVersionPtr version = drmGetVersion(*fd);
version = drmGetVersion(*fd);
if (!version) {
fprintf(stderr, "Retrieving device version failed: %s\n", strerror(errno));
goto fail;
@ -1461,9 +1463,11 @@ try_device(const char *path, int *fd, const char *target)
if (strcmp(version->name, target) != 0)
goto fail;
drmFreeVersion(version);
return true;
fail:
drmFreeVersion(version);
close(*fd);
*fd = -1;
return false;