fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 02:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

agx: Use load_global_constant for UBO lowering

Browse source 
Rely on the common address arithmetic optimizations. We don't need the
special formats for UBO loads anyway, so this is simpler and optimizes
out the ushr.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20558>
This commit is contained in:
Alyssa Rosenzweig 2022-12-03 17:20:54 -05:00 • committed by Marge Bot
parent 3a6a5281b3
commit ac3272be84
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/asahi/compiler/agx_nir_lower_ubo.c
View file

@ -22,15 +22,11 @@ pass(struct nir_builder *b, nir_instr *instr, UNUSED void *data)
nir_ssa_def *ubo_index = nir_ssa_for_src(b, intr->src[0], 1);
nir_ssa_def *offset = nir_ssa_for_src(b, *nir_get_io_offset_src(intr), 1);
unsigned dest_size = nir_dest_bit_size(intr->dest);
assert((dest_size == 16 || dest_size == 32) && "other sizes lowered");
nir_ssa_def *value = nir_load_constant_agx(
b, intr->num_components, dest_size, nir_load_ubo_base_agx(b, ubo_index),
nir_udiv_imm(b, offset, (dest_size / 8)),
.format =
(dest_size == 32) ? AGX_INTERNAL_FORMAT_I32 : AGX_INTERNAL_FORMAT_I16);
nir_ssa_def *address =
nir_iadd(b, nir_load_ubo_base_agx(b, ubo_index), nir_u2u64(b, offset));
nir_ssa_def *value = nir_load_global_constant(
b, address, nir_intrinsic_align(intr), intr->num_components,
nir_dest_bit_size(intr->dest));
nir_ssa_def_rewrite_uses(&intr->dest.ssa, value);
return true;