fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-23 11:40:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panvk: expose subgroup operations

Browse source 
We can't use VK_SHADER_STAGE_ALL here, because we don't support geometry
and tesselation shaders. Additionally, the DDK doesn't support the
vertex stage, so let's not even try that for now; it probably won't
work.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32710>
This commit is contained in:
Erik Faye-Lund 2024-12-16 14:23:11 +01:00 • committed by Marge Bot
parent d2838f3ceb
commit ac05c2a2b8
1 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
src/panfrost/vulkan/panvk_physical_device.c
View file

@ -213,6 +213,7 @@ get_device_extensions(const struct panvk_physical_device *device,
.KHR_shader_float16_int8 = true, .KHR_shader_float16_int8 = true,
.KHR_shader_non_semantic_info = true, .KHR_shader_non_semantic_info = true,
.KHR_shader_relaxed_extended_instruction = true, .KHR_shader_relaxed_extended_instruction = true,
.KHR_shader_subgroup_rotate = true,
.KHR_storage_buffer_storage_class = true, .KHR_storage_buffer_storage_class = true,
#ifdef PANVK_USE_WSI_PLATFORM #ifdef PANVK_USE_WSI_PLATFORM
.KHR_swapchain = true, .KHR_swapchain = true,
@ -345,7 +346,7 @@ get_features(const struct panvk_physical_device *device,
.vulkanMemoryModelAvailabilityVisibilityChains = false, .vulkanMemoryModelAvailabilityVisibilityChains = false,
.shaderOutputViewportIndex = false, .shaderOutputViewportIndex = false,
.shaderOutputLayer = false, .shaderOutputLayer = false,
.subgroupBroadcastDynamicId = false, .subgroupBroadcastDynamicId = true,
/* Vulkan 1.3 */ /* Vulkan 1.3 */
.robustImageAccess = true, .robustImageAccess = true,
@ -364,6 +365,10 @@ get_features(const struct panvk_physical_device *device,
.shaderIntegerDotProduct = false, .shaderIntegerDotProduct = false,
.maintenance4 = false, .maintenance4 = false,
/* Vulkan 1.4 */
.shaderSubgroupRotate = true,
.shaderSubgroupRotateClustered = true,
/* VK_EXT_graphics_pipeline_library */ /* VK_EXT_graphics_pipeline_library */
.graphicsPipelineLibrary = true, .graphicsPipelineLibrary = true,
@ -672,9 +677,29 @@ get_device_properties(const struct panvk_instance *instance,
/* Vulkan 1.1 properties */ /* Vulkan 1.1 properties */
/* XXX: 1.1 support */ /* XXX: 1.1 support */
.subgroupSize = 8, .subgroupSize = pan_subgroup_size(arch),
.subgroupSupportedStages = 0, /* We only support VS, FS, and CS.
.subgroupSupportedOperations = 0, *
* The HW may spawn VS invocations for non-existing indices, which could
* be observed through subgroup ops (though the user can observe them
* through infinte loops anyway), so subgroup ops can't be supported in
* VS.
*
* In FS, voting and potentially other subgroup ops are currently broken,
* so we don't report support for this stage either.
*/
.subgroupSupportedStages = VK_SHADER_STAGE_COMPUTE_BIT,
.subgroupSupportedOperations =
VK_SUBGROUP_FEATURE_BASIC_BIT |
VK_SUBGROUP_FEATURE_VOTE_BIT |
VK_SUBGROUP_FEATURE_ARITHMETIC_BIT |
VK_SUBGROUP_FEATURE_BALLOT_BIT |
VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
VK_SUBGROUP_FEATURE_SHUFFLE_RELATIVE_BIT |
VK_SUBGROUP_FEATURE_CLUSTERED_BIT |
VK_SUBGROUP_FEATURE_QUAD_BIT |
VK_SUBGROUP_FEATURE_ROTATE_BIT |
VK_SUBGROUP_FEATURE_ROTATE_CLUSTERED_BIT,
.subgroupQuadOperationsInAllStages = false, .subgroupQuadOperationsInAllStages = false,
.pointClippingBehavior = VK_POINT_CLIPPING_BEHAVIOR_ALL_CLIP_PLANES, .pointClippingBehavior = VK_POINT_CLIPPING_BEHAVIOR_ALL_CLIP_PLANES,
.maxMultiviewViewCount = arch >= 10 ? 8 : 0, .maxMultiviewViewCount = arch >= 10 ? 8 : 0,