fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-12 00:20:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

tu/kgsl: wait-only submit handling should not ignore sparse bind commands

Browse source 
Commit cf4bd2e412 added a fast path for handling no-command submits to
accommodate a kernel behavior quirk. Sparse support was complete before
that change but landed afterwards, leaving sparse submits that don't have
command buffers but do have sparse bind commands to take that fast path,
leaving the bind commands unhandled. The condition for the fast path is
fixed to address that.

Signed-off-by: Zan Dobersek <zdobersek@igalia.com>
Fixes: 71ef46717c ("tu/kgsl: Add support for sparse binding")
(cherry picked from commit 5b33ee9f0b)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39828>
This commit is contained in:
Zan Dobersek 2026-02-04 17:27:45 +01:00 • committed by Marge Bot
parent cd67481fd2
commit aba5409384
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2424,7 +2424,7 @@
"description": "tu/kgsl: wait-only submit handling should not ignore sparse bind commands",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "71ef46717cd091f0a12a12cf5a8da3ec8a6fe96a",
"notes": null

2
src/freedreno/vulkan/tu_knl_kgsl.cc
View file

@ -1326,7 +1326,7 @@ kgsl_queue_submit(struct tu_queue *queue, void *_submit,
uint64_t start_ts = tu_perfetto_begin_submit();
#endif
if (submit->commands.size == 0) {
if (submit->commands.size == 0 && submit->bind_cmds.size == 0) {
/* This handles the case where we have a wait and no commands to submit.
* It is necessary to handle this case separately as the kernel will not
* advance the GPU timeline if a submit with no commands is made, even