fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-27 16:38:12 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

anv: Improve the fast clear layout perf-warn

Browse source 
anv emits performance warnings earlier about compression being disabled,
so no need to emit this for AUX_NONE. Do provide the tiling however as
Xe2+ supports compressed linear surfaces.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41034>
This commit is contained in:
Nanley Chery 2026-04-23 14:39:35 -04:00 • committed by Marge Bot
parent 8055fefea1
commit ab9a1b4c92
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/intel/vulkan/anv_image.c
View file

@ -4040,6 +4040,9 @@ anv_can_fast_clear_color(const struct anv_cmd_buffer *cmd_buffer,
return false;
}
const uint32_t plane = anv_image_aspect_to_plane(image, clear_aspect);
const struct anv_surface *anv_surf = &image->planes[plane].primary_surface;
/* Start by getting the fast clear type. We use the first subpass
* layout here because we don't want to fast-clear if the first subpass
* to use the attachment can't handle fast-clears.
@ -4050,8 +4053,16 @@ anv_can_fast_clear_color(const struct anv_cmd_buffer *cmd_buffer,
cmd_buffer->queue_family->queueFlags);
switch (fast_clear_type) {
case ANV_FAST_CLEAR_NONE:
anv_perf_warn(VK_LOG_OBJS(&image->vk.base),
"layout does not support fast clear. Slow clearing.");
if (image->planes[plane].aux_usage != ISL_AUX_USAGE_NONE) {
anv_perf_warn(VK_LOG_OBJS(&image->vk.base),
"%s does not support fast clear on %dx%d %s "
"isl_tiling_%s image with usage 0x%x. Slow clearing.",
vk_ImageLayout_to_str(layout),
image->vk.extent.width, image->vk.extent.height,
vk_format_description(image->vk.format)->short_name,
isl_tiling_to_name(anv_surf->isl.tiling),
image->vk.usage);
}
return false;
case ANV_FAST_CLEAR_DEFAULT_VALUE: {
uint32_t view_pixel[4] = {};
@ -4113,8 +4124,6 @@ anv_can_fast_clear_color(const struct anv_cmd_buffer *cmd_buffer,
}
/* Wa_18020603990 - slow clear surfaces up to 256x256, 32bpp. */
const uint32_t plane = anv_image_aspect_to_plane(image, clear_aspect);
const struct anv_surface *anv_surf = &image->planes[plane].primary_surface;
if (intel_needs_workaround(cmd_buffer->device->info, 18020603990)) {
if (isl_format_get_layout(anv_surf->isl.format)->bpb <= 32 &&
anv_surf->isl.logical_level0_px.w <= 256 &&