From ab2a7f32e63fccc3cb68a0db9808aecdd7fabe4a Mon Sep 17 00:00:00 2001 From: Connor Abbott Date: Tue, 24 Oct 2023 12:23:28 +0200 Subject: [PATCH] freedreno/ci: Remove minetest trace I've repeatedly seen minor pixel changes due to changes that only affect RA decisions, most recently in !22072. We changed the trace to hopefully remove a use of texture() in control flow, but it seems there are more, or the problem is something slightly different like reading uninitialized values. On the other hand minetest has never actually caught an issue for me that some other trace hasn't also caught. Just remove it. Cc: mesa-stable Acked-by: David Heidelberg Part-of: (cherry picked from commit 16214710caaacf4fb8539498a3eb774644921249) --- .pick_status.json | 2 +- src/freedreno/ci/traces-freedreno.yml | 34 --------------------------- 2 files changed, 1 insertion(+), 35 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index ef56f428797..645a2b86765 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -954,7 +954,7 @@ "description": "freedreno/ci: Remove minetest trace", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/freedreno/ci/traces-freedreno.yml b/src/freedreno/ci/traces-freedreno.yml index 6887ae78ef0..a870127b04f 100644 --- a/src/freedreno/ci/traces-freedreno.yml +++ b/src/freedreno/ci/traces-freedreno.yml @@ -16,7 +16,6 @@ text: |- stk: 11.15s 0ad: 10.93s counterstrike: 9.87s - minetest: 8.24s neverball: 8.53s traces: @@ -234,39 +233,6 @@ traces: zink-a630: checksum: d25edb433abfcde517b626b3071906ff - minetest/minetest-high-v2.trace: - freedreno-a306: - label: [crash] - freedreno-a530: - checksum: 48d4d4776885fd120429cd36a35ddaf2 - freedreno-a618: - checksum: 2aebe86d6c0488b953bfaacd8000c01a - freedreno-a630: - checksum: 2aebe86d6c0488b953bfaacd8000c01a - zink-a618: - label: [skip, flakes] - checksum: c167b29121b4bbba7675070b2ab1f51a - zink-a630: - label: [skip, flakes] - checksum: c167b29121b4bbba7675070b2ab1f51a - - minetest/minetest-v2.trace: - freedreno-a306: - checksum: 37081a69137df415cfda13dac62966c4 - freedreno-a530: - checksum: 824672b1eef72c0223ac754dfc46e2d5 - freedreno-a618: - checksum: e9b5d984b49f888ff1a4787fe2baea71 - freedreno-a630: - label: [skip, flakes] - checksum: 1db3e8a057748109bd06734860396abf - zink-a618: - checksum: f534d68a62934453325f11ff19e2241a - zink-a630: - label: [skip, flakes] - checksum: f534d68a62934453325f11ff19e2241a - text: occasional Different pixels 1 (no tolerance), 0 (1% tol.) - filament/filament-default.trace: freedreno-a306: label: [unsupported]