fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco/ra: Fix counting of subdword variables in get_reg_create_vector

Browse source 
The loop variable "k" shadowed another variable in the outer scope, so
this loop had no actual effect.

Fixes: 52cc1f8237 ("aco: improve p_create_vector RA for sub-dword operands")
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7427>
(cherry picked from commit 456beb40b8)
This commit is contained in:
Tony Wasserka 2020-11-03 14:40:20 +01:00 • committed by Dylan Baker
parent a37b964ec1
commit aa35378aeb
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -4198,7 +4198,7 @@
"description": "aco/ra: Fix counting of subdword variables in get_reg_create_vector",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "52cc1f8237d9ed0042578777af4b28e5b33c6354"
},

2
src/amd/compiler/aco_register_allocation.cpp
View file

@ -1349,7 +1349,7 @@ PhysReg get_reg_create_vector(ra_ctx& ctx,
PhysReg reg;
reg.reg_b = j * 4;
unsigned bytes_left = bytes - (j - reg_lo) * 4;
for (unsigned k = 0; k < MIN2(bytes_left, 4); k++, reg.reg_b++)
for (unsigned byte_idx = 0; byte_idx < MIN2(bytes_left, 4); byte_idx++, reg.reg_b++)
k += reg_file.test(reg, 1);
} else {
k += 4;