fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-02 09:30:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panfrost: Remove blend shader return value on v9

Browse source 
Removed since there's a new ABI for blend shaders. Even if we always write 0,
it's better not to pack this at all, and to denoise the dumps.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14851>
This commit is contained in:
Alyssa Rosenzweig 2022-01-28 13:47:53 -05:00 • committed by Marge Bot
parent 5d8c659678
commit a98f0e280e
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gallium/drivers/panfrost/pan_cmdstream.c
View file

@ -336,14 +336,17 @@ panfrost_emit_blend(struct panfrost_batch *batch, void *rts, mali_ptr *blend_sha
(blend_shaders[i] & (0xffffffffull << 32)) ==
(fs->bin.gpu & (0xffffffffull << 32)));
unsigned ret_offset = fs->info.bifrost.blend[i].return_offset;
assert(!(ret_offset & 0x7));
pan_pack(&packed->opaque[2], INTERNAL_BLEND, cfg) {
cfg.mode = MALI_BLEND_MODE_SHADER;
cfg.shader.pc = (u32) blend_shaders[i];
#if PAN_ARCH <= 7
unsigned ret_offset = fs->info.bifrost.blend[i].return_offset;
assert(!(ret_offset & 0x7));
cfg.shader.return_value = ret_offset ?
fs->bin.gpu + ret_offset : 0;
#endif
}
} else {
pan_pack(&packed->opaque[2], INTERNAL_BLEND, cfg) {

1
src/panfrost/lib/genxml/v9.xml
View file

@ -548,7 +548,6 @@
</enum>
<struct name="Blend Shader" size="2">
<field name="Return Value" size="29" start="0:3" type="uint" modifier="shr(3)"/>
<field name="PC" size="28" start="1:4" type="uint" modifier="shr(4)"/>
</struct>