From a888889407fb05518f7e07e594b0e5bc900c676c Mon Sep 17 00:00:00 2001 From: Alessio Belle Date: Tue, 15 Jul 2025 11:37:56 +0100 Subject: [PATCH] pvr: Replace check on Mlist size with assert This should slightly simplify a future change. Signed-off-by: Alessio Belle Acked-by: Erik Faye-Lund Part-of: --- src/imagination/vulkan/pvr_job_render.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/imagination/vulkan/pvr_job_render.c b/src/imagination/vulkan/pvr_job_render.c index 43220ed096f..70062d26157 100644 --- a/src/imagination/vulkan/pvr_job_render.c +++ b/src/imagination/vulkan/pvr_job_render.c @@ -595,6 +595,9 @@ pvr_rt_mta_mlist_data_init(struct pvr_device *device, pvr_dev_addr_t dev_addr; VkResult result; + /* No known cores where the Mlist size could be 0 */ + assert(mlist_size > 0); + /* Allocate memory for macrotile array and Mlist for all RT datas. * * Allocation layout: MTA[0..N] + Mlist alignment padding + Mlist[0..N]. @@ -629,12 +632,8 @@ pvr_rt_mta_mlist_data_init(struct pvr_device *device, rt_datas_mta_size); for (uint32_t i = 0; i < num_rt_datas; i++) { - if (mlist_size != 0) { - rt_dataset->rt_datas[i].mlist_dev_addr = dev_addr; - dev_addr = PVR_DEV_ADDR_OFFSET(dev_addr, mlist_size); - } else { - rt_dataset->rt_datas[i].mlist_dev_addr = PVR_DEV_ADDR_INVALID; - } + rt_dataset->rt_datas[i].mlist_dev_addr = dev_addr; + dev_addr = PVR_DEV_ADDR_OFFSET(dev_addr, mlist_size); } return VK_SUCCESS;