fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-21 07:40:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

brw/const: Allow mixing signed and unsigned immediate sources

Browse source 
No shader-db or fossil-db changes on any Intel platform. This commit
just prevents issues with a later commit, "brw/copy: Don't try to be
clever about ADD3 constant propagation."

v2: Use 'can_promote = true; break;' instead of 'return
true;'. Suggested by Caio.

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32436>
This commit is contained in:
Ian Romanick 2024-11-26 15:12:32 -08:00 • committed by Marge Bot
parent a738c55d7b
commit a84e3a0f55
1 changed files with 22 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/intel/compiler/brw_fs_combine_constants.cpp
View file

@ -1049,19 +1049,29 @@ can_promote_src_as_imm(const struct intel_device_info *devinfo, fs_inst *inst,
}
break;
}
case BRW_TYPE_D: {
int16_t w;
if (representable_as_w(inst->src[src_idx].d, &w)) {
inst->src[src_idx] = brw_imm_w(w);
can_promote = true;
}
break;
}
case BRW_TYPE_D:
case BRW_TYPE_UD: {
uint16_t uw;
if (representable_as_uw(inst->src[src_idx].ud, &uw)) {
inst->src[src_idx] = brw_imm_uw(uw);
can_promote = true;
/* ADD3, CSEL, and MAD can mix signed and unsiged types. Only BFE
* cannot.
*/
if (inst->src[src_idx].type == BRW_TYPE_D ||
inst->opcode != BRW_OPCODE_BFE) {
int16_t w;
if (representable_as_w(inst->src[src_idx].d, &w)) {
inst->src[src_idx] = brw_imm_w(w);
can_promote = true;
break;
}
}
if (inst->src[src_idx].type == BRW_TYPE_UD ||
inst->opcode != BRW_OPCODE_BFE) {
uint16_t uw;
if (representable_as_uw(inst->src[src_idx].ud, &uw)) {
inst->src[src_idx] = brw_imm_uw(uw);
can_promote = true;
break;
}
}
break;
}