fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-11 23:10:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

mesa: allow GL_UNSIGNED_BYTE type for SNORM reads

Browse source 
OpenGL ES spec states:
   "For normalized fixed-point rendering surfaces, the combination format
    RGBA and type UNSIGNED_BYTE is accepted."

This fixes following failing VK-GL-CTS tests:

   KHR-GLES3.packed_pixels.pbo_rectangle.rgba8_snorm
   KHR-GLES3.packed_pixels.rectangle.rgba8_snorm
   KHR-GLES3.packed_pixels.varied_rectangle.rgba8_snorm

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
https://bugs.freedesktop.org/show_bug.cgi?id=107658
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Tested-by: Andres Gomez <agomez@igalia.com>
This commit is contained in:
Tapani Pälli 2018-08-27 14:40:41 +03:00
parent 5db981952a
commit a72dbc461b
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/mesa/main/readpix.c
View file

@ -958,6 +958,15 @@ read_pixels_es3_error_check(struct gl_context *ctx, GLenum format, GLenum type,
return GL_NO_ERROR;
}
}
if (type == GL_UNSIGNED_BYTE) {
switch (internalFormat) {
case GL_R8_SNORM:
case GL_RG8_SNORM:
case GL_RGBA8_SNORM:
if (_mesa_has_EXT_render_snorm(ctx))
return GL_NO_ERROR;
}
}
break;
case GL_BGRA:
/* GL_EXT_read_format_bgra */