From a70279adc26d825d285f84bc8a0150ef67f084e7 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Sat, 6 Sep 2025 16:49:59 -0700 Subject: [PATCH] freedreno/registers: Re-enable validation for gen_header.py Commit 84e93daa2656 ("freedreno/registers: allow skipping the validation") synced a change that made validation optional for kernel builds, to avoid a lxml dependency for kernel builds. But this inadvertantly also disabled schema validation on the mesa side. CI (and meson "test" target) still validates the xml against the schema, but it is easier if this is also done as part of the normal build to avoid suprises from Marge. Fixes: 84e93daa2656 ("freedreno/registers: allow skipping the validation") Signed-off-by: Rob Clark Part-of: --- src/freedreno/registers/adreno/meson.build | 2 +- src/freedreno/registers/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/freedreno/registers/adreno/meson.build b/src/freedreno/registers/adreno/meson.build index 7f15de915ec..78204a9e67b 100644 --- a/src/freedreno/registers/adreno/meson.build +++ b/src/freedreno/registers/adreno/meson.build @@ -32,7 +32,7 @@ foreach f : xml_files _name, input: [gen_header_py, f, freedreno_schema, freedreno_copyright], output: _name, - command: [prog_python, '@INPUT0@', '--rnn', rnn_src_path, '--xml', '@INPUT1@', 'c-defines'], + command: [prog_python, '@INPUT0@', '--validate', '--rnn', rnn_src_path, '--xml', '@INPUT1@', 'c-defines'], capture: true, ) _gzname = f + '.gz' diff --git a/src/freedreno/registers/meson.build b/src/freedreno/registers/meson.build index d6b91a22ef6..d044707834e 100644 --- a/src/freedreno/registers/meson.build +++ b/src/freedreno/registers/meson.build @@ -22,7 +22,7 @@ foreach f : xml_files _name, input: [gen_header_py, f, freedreno_schema, freedreno_copyright], output: _name, - command: [prog_python, '@INPUT0@', '--rnn', rnn_src_path, '--xml', '@INPUT1@', 'c-defines'], + command: [prog_python, '@INPUT0@', '--validate', '--rnn', rnn_src_path, '--xml', '@INPUT1@', 'c-defines'], capture: true, ) endforeach