fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 02:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: fix DCC enablement since partial MSAA implementation

Browse source 
dcc_msaa_allowed is always false on GFX9+ and only true on VI
if RADV_PERFTEST=dccmsaa is set. This means DCC was disabled
in some situations where it should not.

This is likely going to fix a performance regression.

Fixes: 2f63b3dd09 ("radv: enable DCC for MSAA 2x textures on VI under an option")
Cc: 18.1 <mesa-stable@lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
This commit is contained in:
Samuel Pitoiset 2018-04-25 10:56:15 +02:00
parent 227b1af866
commit a6fbefa67b
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/amd/vulkan/radv_image.c
View file

@ -133,12 +133,12 @@ radv_use_dcc_for_image(struct radv_device *device,
if (create_info->scanout) if (create_info->scanout)
return false; return false;
/* FIXME: DCC for MSAA with 4x and 8x samples doesn't work yet. */ /* FIXME: DCC for MSAA with 4x and 8x samples doesn't work yet, while
if (pCreateInfo->samples > 2) * 2x can be enabled with an option.
return false; */
if (pCreateInfo->samples > 2 ||
/* TODO: Enable DCC for MSAA textures. */ (pCreateInfo->samples == 2 &&
if (!device->physical_device->dcc_msaa_allowed) !device->physical_device->dcc_msaa_allowed))
return false; return false;
/* Determine if the formats are DCC compatible. */ /* Determine if the formats are DCC compatible. */