fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-30 16:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/mda: Use a vector to track the contents variable
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
I'm not really sure why Coverity doesn't tag the `delete[]` as a
potential leak since it also happens after ASSERT macros, like it did
with the call to `fclose()`.

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37744>
This commit is contained in:
Dylan Baker 2025-10-27 20:07:58 +00:00 • committed by Marge Bot
parent 9509d0d8b8
commit a6102f7432
1 changed files with 14 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/intel/mda/tar_test.cpp
View file

@ -3,10 +3,13 @@
* SPDX-License-Identifier: MIT
*/
#include <gtest/gtest.h>
#include <cstring>
#include "tar.h"
#include <gtest/gtest.h>
#include <cstring>
#include <vector>
class TarTest : public testing::Test {
protected:
TarTest() : f{std::tmpfile()} {};
@ -35,14 +38,14 @@ TEST_F(TarTest, RoundtripSmallFile)
long size = ftell(f);
ASSERT_TRUE(size > 0);
ASSERT_TRUE(size % 512 == 0);
char *contents = new char[size];
std::vector<char> contents(size);
fseek(f, 0, SEEK_SET);
ASSERT_EQ(fread(contents, size, 1, f), 1);
ASSERT_EQ(fread(contents.data(), size, 1, f), 1);
{
tar_reader ar;
tar_reader_init_from_bytes(&ar, contents, size);
tar_reader_init_from_bytes(&ar, contents.data(), size);
tar_reader_entry entry;
@ -58,8 +61,6 @@ TEST_F(TarTest, RoundtripSmallFile)
bool second_read = tar_reader_next(&ar, &entry);
ASSERT_FALSE(second_read);
}
delete[] contents;
}
TEST_F(TarTest, RoundtripContentsWithRecordSize)
@ -81,14 +82,14 @@ TEST_F(TarTest, RoundtripContentsWithRecordSize)
long size = ftell(f);
ASSERT_TRUE(size > 0);
ASSERT_TRUE(size % 512 == 0);
char *contents = new char[size];
std::vector<char> contents(size);
fseek(f, 0, SEEK_SET);
ASSERT_EQ(fread(contents, size, 1, f), 1);
ASSERT_EQ(fread(contents.data(), size, 1, f), 1);
{
tar_reader ar;
tar_reader_init_from_bytes(&ar, contents, size);
tar_reader_init_from_bytes(&ar, contents.data(), size);
ASSERT_FALSE(ar.error);
tar_reader_entry entry;
@ -105,8 +106,6 @@ TEST_F(TarTest, RoundtripContentsWithRecordSize)
bool second_read = tar_reader_next(&ar, &entry);
ASSERT_FALSE(second_read);
}
delete[] contents;
}
TEST_F(TarTest, TimestampRoundtrip)
@ -127,14 +126,14 @@ TEST_F(TarTest, TimestampRoundtrip)
long size = ftell(f);
ASSERT_TRUE(size > 0);
ASSERT_TRUE(size % 512 == 0);
char *contents = new char[size];
std::vector<char> contents(size);
fseek(f, 0, SEEK_SET);
ASSERT_EQ(fread(contents, size, 1, f), 1);
ASSERT_EQ(fread(contents.data(), size, 1, f), 1);
{
tar_reader ar;
tar_reader_init_from_bytes(&ar, contents, size);
tar_reader_init_from_bytes(&ar, contents.data(), size);
ASSERT_FALSE(ar.error);
tar_reader_entry entry;
@ -154,6 +153,4 @@ TEST_F(TarTest, TimestampRoundtrip)
bool second_read = tar_reader_next(&ar, &entry);
ASSERT_FALSE(second_read);
}
delete[] contents;
}