From a5d5cbdf080d7c1bb6a81ee838f06694eeb6ea0c Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sun, 28 Mar 2021 20:24:27 -0700 Subject: [PATCH] freedreno: Fix file descriptor leak. Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_handle: Handle variable fd going out of scope leaks the handle. Fixes: 5a13507164a ("freedreno/perfcntrs: add fdperf") Signed-off-by: Vinson Lee Part-of: --- src/freedreno/perfcntrs/freedreno_dt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/freedreno/perfcntrs/freedreno_dt.c b/src/freedreno/perfcntrs/freedreno_dt.c index 4dba61854bb..1c5e5e93eab 100644 --- a/src/freedreno/perfcntrs/freedreno_dt.c +++ b/src/freedreno/perfcntrs/freedreno_dt.c @@ -246,10 +246,9 @@ fd_dt_find_io(void) return NULL; void *io = mmap(0, dev.size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, dev.base); - if (io == MAP_FAILED) { - close(fd); + close(fd); + if (io == MAP_FAILED) return NULL; - } return io; }