fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-24 10:20:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

anv: Don't support ASTC images with modifiers

Browse source 
Before this change, anv_get_image_format_features2 reported support for
ASTC formats with any modifier (even those not supported by anv). But,
we didn't intend to support that compressed image format with modifiers.

With this change, the format feature function reports no support for
modifiers on ASTC-formatted images.

This prevents the next patch from causing assertion failures due to
unsupported modifiers.

Fixes: 355f318843 ("anv: Allow transfer-only linear ASTC images")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24120>
(cherry picked from commit e50af52e3d)
This commit is contained in:
Nanley Chery 2023-07-20 09:40:04 -04:00 • committed by Dylan Baker
parent b1e6110c32
commit a5a2cc6c2a
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3584,7 +3584,7 @@
"description": "anv: Don't support ASTC images with modifiers",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "355f3188438d22712850d65e48660d8f46316dc5",
"notes": null

13
src/intel/vulkan/anv_formats.c
View file

@ -577,11 +577,16 @@ anv_get_image_format_features2(const struct anv_physical_device *physical_device
enum isl_format base_isl_format = base_plane_format.isl_format;
if (isl_format_supports_sampling(devinfo, plane_format.isl_format)) {
/* ASTC textures must be in Y-tiled memory, and we reject compressed
* formats with modifiers. We do however interpret ASTC textures with
* uncompressed formats during data transfers.
/* Unlike other surface formats, our sampler requires that the ASTC
* format only be used on surfaces in non-linearly-tiled memory.
* Thankfully, we can make an exception for linearly-tiled images that
* are only used for transfers. blorp_copy will reinterpret any
* compressed format to an uncompressed one.
*
* We handle modifier tilings further down in this function.
*/
if (vk_tiling != VK_IMAGE_TILING_OPTIMAL &&
if (vk_tiling == VK_IMAGE_TILING_LINEAR &&
isl_format_get_layout(plane_format.isl_format)->txc == ISL_TXC_ASTC)
return VK_FORMAT_FEATURE_2_TRANSFER_SRC_BIT |
VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT;