From a5967f308ca9f67a83ba73167536c7f96a27500d Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Fri, 18 Sep 2020 15:21:14 -0700 Subject: [PATCH] pan/bi: Fix typo. Fix defect reported by Coverity Scan. Same on both sides (CONSTANT_EXPRESSION_RESULT) pointless_expression: The expression src0_u8 || src0_u8 does not accomplish anything because it evaluates to either of its identical operands, src0_u8. Fixes: 2ff53879f214 ("pan/bi: Use new packing") Signed-off-by: Vinson Lee Reviewed-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bi_pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/bifrost/bi_pack.c b/src/panfrost/bifrost/bi_pack.c index 51509d5c12d..9ec735236bf 100644 --- a/src/panfrost/bifrost/bi_pack.c +++ b/src/panfrost/bifrost/bi_pack.c @@ -698,7 +698,7 @@ bi_pack_add(bi_clause *clause, bi_bundle bundle, bi_registers *regs, gl_shader_s return pan_pack_add_icmp_i32(clause, bundle.add, regs); else if ((src0_u16 || src0_s16) && typeless_cond) return pan_pack_add_icmp_v2i16(clause, bundle.add, regs); - else if ((src0_u8 || src0_u8) && typeless_cond) + else if ((src0_u8 || src0_s8) && typeless_cond) return pan_pack_add_icmp_v4i8(clause, bundle.add, regs); else if (src0_u32) return pan_pack_add_icmp_u32(clause, bundle.add, regs);