fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-25 23:10:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco/live_var_analysis: set same lateKill flags for same operands

Browse source 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34359>
This commit is contained in:
Daniel Schürmann 2025-05-16 13:19:25 +02:00 • committed by Marge Bot
parent ee0ee282b9
commit a4fa3935fd
1 changed files with 25 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
src/amd/compiler/aco_live_var_analysis.cpp
View file

@ -213,6 +213,22 @@ process_live_temps_per_block(live_ctx& ctx, Block* block)
}
}
/* we need to do this in a separate loop because the next one can
* setKill() for several operands at once and we don't want to
* overwrite that in a later iteration */
for (Operand& op : insn->operands) {
op.setKill(false);
/* Linear vgprs must be late kill: this is to ensure linear VGPR operands and
* normal VGPR definitions don't try to use the same register, which is problematic
* because of assignment restrictions.
*/
if (op.hasRegClass() && op.regClass().is_linear_vgpr() && !op.isUndefined() &&
has_vgpr_def)
op.setLateKill(true);
else
op.setLateKill(false);
}
if (ctx.program->gfx_level >= GFX10 && insn->isVALU() &&
insn->definitions.back().regClass() == s2) {
/* RDNA2 ISA doc, 6.2.4. Wave64 Destination Restrictions:
@ -244,23 +260,8 @@ process_live_temps_per_block(live_ctx& ctx, Block* block)
insn->operands[1].setLateKill(true);
}
/* we need to do this in a separate loop because the next one can
* setKill() for several operands at once and we don't want to
* overwrite that in a later iteration */
for (Operand& op : insn->operands) {
op.setKill(false);
/* Linear vgprs must be late kill: this is to ensure linear VGPR operands and
* normal VGPR definitions don't try to use the same register, which is problematic
* because of assignment restrictions.
*/
if (op.hasRegClass() && op.regClass().is_linear_vgpr() && !op.isUndefined() &&
has_vgpr_def)
op.setLateKill(true);
}
RegisterDemand operand_demand;
/* Check if a definition clobbers some operand */
RegisterDemand operand_demand;
auto tied_defs = get_tied_defs(insn);
for (auto op_idx : tied_defs) {
Temp tmp = insn->operands[op_idx].getTemp();
@ -305,6 +306,14 @@ process_live_temps_per_block(live_ctx& ctx, Block* block)
}
}
if (operand.isLateKill()) {
/* Make sure that same temporaries have same lateKill flags. */
for (Operand& other : insn->operands) {
if (other.isTemp() && other.getTemp() == operand.getTemp())
other.setLateKill(true);
}
}
if (operand.isKill())
continue;