From a4dc18efcab396a9d2f696c6a40b41bb239ecce6 Mon Sep 17 00:00:00 2001 From: Roland Scheidegger Date: Fri, 1 Sep 2017 01:48:42 +0200 Subject: [PATCH] st/mesa: fix view template initialization in try_pbo_readpixels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I think this is what the code was meant to do, albeit as far as I can tell the redundant initialization some analyzers complain about should work as well just fine (only the first layer will be used, if the view contains one or more layers doesn't really matter). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102467 Reviewed-by: Brian Paul Reviewed-by: Marek Olšák Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 2b2c61f0df5c18355b65772d21be36339ba5e1d9) --- src/mesa/state_tracker/st_cb_readpixels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c index 0bcf2eb4fdf..84dd2d548e3 100644 --- a/src/mesa/state_tracker/st_cb_readpixels.c +++ b/src/mesa/state_tracker/st_cb_readpixels.c @@ -175,7 +175,7 @@ try_pbo_readpixels(struct st_context *st, struct st_renderbuffer *strb, if (view_target != PIPE_TEXTURE_3D) { templ.u.tex.first_layer = surface->u.tex.first_layer; - templ.u.tex.last_layer = templ.u.tex.last_layer; + templ.u.tex.last_layer = templ.u.tex.first_layer; } else { addr.constants.layer_offset = surface->u.tex.first_layer; }