fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-04 02:40:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

anv: Get rid of the stub() macros

Browse source 
Except for a few unimplemented things on gen7, we don't really have
stubs anymore so we should drop this.  This commit replaces the few gen7
stub() calls with explicitly labeled finishme's and makes the sparse
binding stuff silently no-op or return a FEATURE_NOT_PRESENT error.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
This commit is contained in:
Jason Ekstrand 2017-03-07 09:19:29 -08:00
parent 1488d079cb
commit a316d8f406
3 changed files with 5 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/intel/vulkan/anv_device.c
View file

@ -1603,7 +1603,7 @@ void anv_GetImageSparseMemoryRequirements(
uint32_t* pSparseMemoryRequirementCount,
VkSparseImageMemoryRequirements* pSparseMemoryRequirements)
{
stub();
*pSparseMemoryRequirementCount = 0;
}
void anv_GetDeviceMemoryCommitment(
@ -1640,7 +1640,7 @@ VkResult anv_QueueBindSparse(
const VkBindSparseInfo* pBindInfo,
VkFence fence)
{
stub_return(VK_ERROR_INCOMPATIBLE_DRIVER);
return vk_error(VK_ERROR_FEATURE_NOT_PRESENT);
}
VkResult anv_CreateFence(

12
src/intel/vulkan/anv_private.h
View file

@ -279,18 +279,6 @@ void anv_loge_v(const char *format, va_list va);
#define anv_validate if (0)
#endif
#define stub_return(v) \
do { \
anv_finishme("stub %s", __func__); \
return (v); \
} while (0)
#define stub() \
do { \
anv_finishme("stub %s", __func__); \
return; \
} while (0)
/**
* A dynamically growable, circular buffer. Elements are added at head and
* removed from tail. head and tail are free-running uint32_t indices and we

6
src/intel/vulkan/gen7_cmd_buffer.c
View file

@ -270,7 +270,7 @@ void genX(CmdSetEvent)(
VkEvent event,
VkPipelineStageFlags stageMask)
{
stub();
anv_finishme("Implement events on gen7");
}
void genX(CmdResetEvent)(
@ -278,7 +278,7 @@ void genX(CmdResetEvent)(
VkEvent event,
VkPipelineStageFlags stageMask)
{
stub();
anv_finishme("Implement events on gen7");
}
void genX(CmdWaitEvents)(
@ -294,7 +294,7 @@ void genX(CmdWaitEvents)(
uint32_t imageMemoryBarrierCount,
const VkImageMemoryBarrier* pImageMemoryBarriers)
{
stub();
anv_finishme("Implement events on gen7");
genX(CmdPipelineBarrier)(commandBuffer, srcStageMask, destStageMask,
false, /* byRegion */