From a3013b1df4fb9ddb5ebae913b50f66cc9acf1c76 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Tue, 29 Nov 2022 08:41:14 +0100 Subject: [PATCH] radv: do not enable NGG culling on GFX11 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RadeonSI disables it as well. It's really unclear if it will help or not (eg. NGG culling never helped on GFX10). Cc: 22.3 mesa-stable Signed-off-by: Samuel Pitoiset Reviewed-by: Timur Kristóf Reviewed-by: Bas Nieuwenhuizen Part-of: (cherry picked from commit 5d552b4f6cbfcb4bf14e3a0bdce01cc00eb61073) --- .pick_status.json | 2 +- src/amd/vulkan/radv_device.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 6259698ab62..b8c57706eaf 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -121,7 +121,7 @@ "description": "radv: do not enable NGG culling on GFX11", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 16b637e2eb8..b1e816f3dfb 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -869,8 +869,9 @@ radv_physical_device_try_create(struct radv_instance *instance, drmDevicePtr drm !(device->instance->debug_flags & RADV_DEBUG_NO_NGG)) || device->rad_info.gfx_level >= GFX11; + /* TODO: Investigate if NGG culling helps on GFX11. */ device->use_ngg_culling = device->use_ngg && device->rad_info.max_render_backends > 1 && - (device->rad_info.gfx_level >= GFX10_3 || + (device->rad_info.gfx_level == GFX10_3 || (device->instance->perftest_flags & RADV_PERFTEST_NGGC)) && !(device->instance->debug_flags & RADV_DEBUG_NO_NGGC);