fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-05 02:30:18 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

vulkan: enum generator: Stop using iterparse

Browse source 
While using iterparse is potentially a little more efficient, the Vulkan
registry XML is not large and using regular element tree simplifies the
parsing logic substantially.

Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
This commit is contained in:
Jason Ekstrand 2017-09-21 08:05:25 -07:00
parent 0ee868c1f6
commit a2fa09efd3
1 changed files with 8 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/vulkan/util/gen_enum_to_str.py
View file

@ -157,32 +157,16 @@ def parse_xml(enum_factory, ext_factory, filename):
of VkEnum objects.
"""
with open(filename, 'rb') as f:
context = iter(et.iterparse(f, events=('start', 'end')))
xml = et.parse(filename)
# This gives the root element, since goal is to iterate over the
# elements without building a tree, this allows the root to be cleared
# (erase the elements) after the children have been processed.
_, root = next(context)
for enum_type in xml.findall('./enums[@type="enum"]'):
enum = enum_factory(enum_type.attrib['name'])
for value in enum_type.findall('./enum'):
enum.values.append(value.attrib['name'])
for event, elem in context:
if event == 'end' and elem.tag == 'enums':
type_ = elem.attrib.get('type')
if type_ == 'enum':
enum = enum_factory(elem.attrib['name'])
enum.values.extend([e.attrib['name'] for e in elem
if e.tag == 'enum'])
elif event == 'start' and elem.tag == 'extension':
ext_factory(elem.attrib['name'],
number=int(elem.attrib['number']))
elif event == 'end' and elem.tag == 'extension':
if elem.attrib['supported'] != 'vulkan':
continue
for e in elem.findall('.//enum[@extends][@offset]'):
enum = enum_factory(e.attrib['extends'])
enum.values.append(e.attrib['name'])
root.clear()
for ext_elem in xml.findall('./extensions/extension[@supported="vulkan"]'):
ext_factory(ext_elem.attrib['name'],
number=int(ext_elem.attrib['number']))
def main():
parser = argparse.ArgumentParser()