From a245b397c66a1a9a1a21aa99d9fa42f2f9716104 Mon Sep 17 00:00:00 2001 From: Constantine Shablia Date: Thu, 31 Oct 2024 00:34:57 +0000 Subject: [PATCH] panvk: elaborate the comment on the maxMemoryAllocationCount limit Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/panvk_physical_device.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 32e73eec1b1..608447bccd6 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -439,7 +439,12 @@ get_device_properties(const struct panvk_instance *instance, * requirements. */ .maxPushConstantsSize = 128, - /* There's no HW limit here. Should we advertize something smaller? */ + /* On our kernel drivers we're limited by the available memory rather + * than available allocations. This is better expressed through memory + * properties and budget queries, and by returning + * VK_ERROR_OUT_OF_DEVICE_MEMORY when applicable, rather than + * this limit. + */ .maxMemoryAllocationCount = UINT32_MAX, /* Again, no hardware limit, but most drivers seem to advertive 64k. */ .maxSamplerAllocationCount = 64 * 1024,