fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 13:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

i965/fs_surface_builder: Mask signed integers after conversion

Browse source 
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
This commit is contained in:
Jason Ekstrand 2016-01-18 17:30:59 -08:00
parent 3921b64e63
commit a241ab43b5
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp
View file

@ -717,6 +717,15 @@ namespace {
bld.emit_minmax(offset(dst, bld, c), offset(dst, bld, c),
brw_imm_d(-(int)scale(widths[c] - s) - 1),
BRW_CONDITIONAL_GE);
/* Mask off all but the bits we actually want. Otherwise, if
* we pass a negative number into the hardware when it's
* expecting something like UINT8, it will happily clamp it to
* +255 for us.
*/
if (is_signed && widths[c] < 32)
bld.AND(offset(dst, bld, c), offset(dst, bld, c),
brw_imm_d(scale(widths[c])));
}
}
@ -787,6 +796,15 @@ namespace {
/* Convert to integer. */
bld.RNDE(offset(fdst, bld, c), offset(fdst, bld, c));
bld.MOV(offset(dst, bld, c), offset(fdst, bld, c));
/* Mask off all but the bits we actually want. Otherwise, if
* we pass a negative number into the hardware when it's
* expecting something like UINT8, it will happily clamp it to
* +255 for us.
*/
if (is_signed && widths[c] < 32)
bld.AND(offset(dst, bld, c), offset(dst, bld, c),
brw_imm_d(scale(widths[c])));
}
}