fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 11:08:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk: improve should_split_render_pass

Browse source 
Fragments are processed in rasterization order within a fragment job.
The fragment subqueue self-wait is nop in most cases.  The only
exception is when there is a feedback loop.

When there is a feedback loop, because we lower subpassLoad to
texelFetch, we have to split the render pass.

Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32074>
This commit is contained in:
Chia-I Wu 2024-11-09 20:17:38 -08:00 • committed by Marge Bot
parent bee7ef4670
commit a23c0eb61a
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/panfrost/vulkan/csf/panvk_vX_cmd_buffer.c
View file

@ -331,7 +331,8 @@ add_memory_dependency(struct panvk_cache_flush_info *cache_flush,
}
static bool
should_split_render_pass(const uint32_t wait_masks[static PANVK_SUBQUEUE_COUNT])
should_split_render_pass(const uint32_t wait_masks[static PANVK_SUBQUEUE_COUNT],
VkAccessFlags2 src_access, VkAccessFlags2 dst_access)
{
/* From the Vulkan 1.3.301 spec:
*
@ -349,9 +350,14 @@ should_split_render_pass(const uint32_t wait_masks[static PANVK_SUBQUEUE_COUNT])
BITFIELD_BIT(PANVK_SUBQUEUE_FRAGMENT))
return true;
/* split if the fragment subqueue self-waits */
if (wait_masks[PANVK_SUBQUEUE_FRAGMENT] &
BITFIELD_BIT(PANVK_SUBQUEUE_FRAGMENT))
/* split if the fragment subqueue self-waits with a feedback loop, because
* we lower subpassLoad to texelFetch
*/
if ((wait_masks[PANVK_SUBQUEUE_FRAGMENT] &
BITFIELD_BIT(PANVK_SUBQUEUE_FRAGMENT)) &&
(src_access & (VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT |
VK_ACCESS_2_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT)) &&
(dst_access & VK_ACCESS_2_INPUT_ATTACHMENT_READ_BIT))
return true;
return false;
@ -382,7 +388,7 @@ collect_cs_deps(struct panvk_cmd_buffer *cmdbuf,
/* within a render pass */
if (cmdbuf->state.gfx.render.tiler) {
if (should_split_render_pass(wait_masks)) {
if (should_split_render_pass(wait_masks, src_access, dst_access)) {
deps->needs_draw_flush = true;
} else {
/* skip the tiler subqueue self-wait because we use the same