fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 15:38:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

isl: Pick a better initial state for zeroed MCS

Browse source 
Pick the compressed-no-clear aux state instead of aux-invalid state to
reduce ambiguates in iris. Hopefully this will help debug the issues
seen around MCS-enabling on ACM.

Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27881>
This commit is contained in:
Nanley Chery 2024-02-27 10:39:17 -05:00 • committed by Marge Bot
parent 5775bc0c53
commit a1e3c93ff7
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/intel/isl/isl_aux_info.c
View file

@ -136,9 +136,24 @@ isl_aux_get_initial_state(const struct intel_device_info *devinfo,
case ISL_AUX_USAGE_HIZ:
case ISL_AUX_USAGE_HIZ_CCS:
case ISL_AUX_USAGE_HIZ_CCS_WT:
return ISL_AUX_STATE_AUX_INVALID;
case ISL_AUX_USAGE_MCS:
case ISL_AUX_USAGE_MCS_CCS:
return ISL_AUX_STATE_AUX_INVALID;
if (zeroed) {
/* From the Sky Lake PRM, "Compressed Multisampled Surfaces":
*
* "An MCS value of 0x00 indicates that both samples are stored in
* sample slice 0 (thus have the same color). This is the fully
* compressed case."
*
* This quote is from the 2x MSAA section, but the same mapping
* exists for 4-16x MSAA. This state can avoid the need to ambiguate
* in some cases.
*/
return ISL_AUX_STATE_COMPRESSED_NO_CLEAR;
} else {
return ISL_AUX_STATE_AUX_INVALID;
}
case ISL_AUX_USAGE_CCS_D:
case ISL_AUX_USAGE_CCS_E:
case ISL_AUX_USAGE_FCV_CCS_E: