fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-25 21:00:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco: Initialize ds_state.front.writeMask.

Browse source 
Fix defect reported by Coverity Scan.

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value ds_state.front. Field ds_state.front.writeMask is uninitialized.

Fixes: d488d0fd7b ("aco: add framework for testing isel and integration tests")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9033>
(cherry picked from commit 7cc83f237e)
This commit is contained in:
Vinson Lee 2021-02-13 20:21:55 -08:00 • committed by Dylan Baker
parent f8921a493b
commit a0f4bac7dc
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1111,7 +1111,7 @@
"description": "aco: Initialize ds_state.front.writeMask.",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "d488d0fd7baff77204dbd3fd0d625b5974728534"
},

1
src/amd/compiler/tests/helpers.cpp
View file

@ -647,6 +647,7 @@ void PipelineBuilder::create_graphics_pipeline() {
ds_state.front.depthFailOp = VK_STENCIL_OP_REPLACE;
ds_state.front.compareOp = VK_COMPARE_OP_ALWAYS;
ds_state.front.compareMask = 0xffffffff,
ds_state.front.writeMask = 0;
ds_state.front.reference = 0;
ds_state.back = ds_state.front;