fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-26 04:40:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Avoid double unlock.

Browse source 
Fix defect reported by Coverity Scan.

Double unlock (LOCK)
double_unlock: pthread_mutex_unlock unlocks dev->indirect_draw_shaders.lock while it is unlocked.

Fixes: 2e6d94c198 ("panfrost: Add helpers to support indirect draws")
Suggested-by: Alyssa Rosenzweig <alyssa@collabora.com>
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14262>
This commit is contained in:
Vinson Lee 2021-12-19 20:08:37 -08:00 • committed by Marge Bot
parent 1d6f6f9102
commit 9f8a204645
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/panfrost/lib/pan_indirect_draw.c
View file

@ -1168,7 +1168,6 @@ create_indirect_draw_shader(struct panfrost_device *dev,
pan_pack(state, RENDERER_STATE, cfg) {
pan_shader_prepare_rsd(&shader_info, address, &cfg);
}
pthread_mutex_unlock(&dev->indirect_draw_shaders.lock);
draw_shader->push = shader_info.push;
draw_shader->rsd = dev->indirect_draw_shaders.states->ptr.gpu +