From 9f80fc3d70ca6138dfa5e1d1ad7796005fc09dbc Mon Sep 17 00:00:00 2001 From: Caio Oliveira Date: Sat, 10 Feb 2024 19:58:07 -0800 Subject: [PATCH] intel/elk: Remove unused SEND features Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/compiler/elk/elk_compiler.h | 7 ------- src/intel/compiler/elk/elk_ir.h | 7 ------- src/intel/compiler/elk/elk_lower_logical_sends.cpp | 3 --- 3 files changed, 17 deletions(-) diff --git a/src/intel/compiler/elk/elk_compiler.h b/src/intel/compiler/elk/elk_compiler.h index 128b3948267..c0293940a22 100644 --- a/src/intel/compiler/elk/elk_compiler.h +++ b/src/intel/compiler/elk/elk_compiler.h @@ -116,13 +116,6 @@ struct elk_compiler { */ bool indirect_ubos_use_sampler; - /** - * Gfx12.5+ has a bit in the SEND instruction extending the bindless - * surface offset range from 20 to 26 bits, effectively giving us 4Gb of - * bindless surface descriptors instead of 64Mb previously. - */ - bool extended_bindless_surface_offset; - /** * Gfx11+ has a bit in the dword 3 of the sampler message header that * indicates whether the sampler handle is relative to the dynamic state diff --git a/src/intel/compiler/elk/elk_ir.h b/src/intel/compiler/elk/elk_ir.h index 19019d2c15a..32574217627 100644 --- a/src/intel/compiler/elk/elk_ir.h +++ b/src/intel/compiler/elk/elk_ir.h @@ -177,13 +177,6 @@ struct elk_backend_instruction { bool check_tdr:1; /**< Only valid for SEND; turns it into a SENDC */ bool send_has_side_effects:1; /**< Only valid for ELK_SHADER_OPCODE_SEND */ bool send_is_volatile:1; /**< Only valid for ELK_SHADER_OPCODE_SEND */ - bool send_ex_desc_scratch:1; /**< Only valid for ELK_SHADER_OPCODE_SEND, use - * the scratch surface offset to build - * extended descriptor - */ - bool send_ex_bso:1; /**< Only for ELK_SHADER_OPCODE_SEND, use extended bindless - * surface offset (26bits instead of 20bits) - */ bool predicate_trivial:1; /**< The predication mask applied to this * instruction is guaranteed to be uniform and * a superset of the execution mask of the diff --git a/src/intel/compiler/elk/elk_lower_logical_sends.cpp b/src/intel/compiler/elk/elk_lower_logical_sends.cpp index 587e2db6210..6b19f87b102 100644 --- a/src/intel/compiler/elk/elk_lower_logical_sends.cpp +++ b/src/intel/compiler/elk/elk_lower_logical_sends.cpp @@ -1313,7 +1313,6 @@ setup_surface_descriptors(const fs_builder &bld, elk_fs_inst *inst, uint32_t des static void lower_surface_logical_send(const fs_builder &bld, elk_fs_inst *inst) { - const elk_compiler *compiler = bld.shader->compiler; const intel_device_info *devinfo = bld.shader->devinfo; /* Get the logical send arguments. */ @@ -1523,8 +1522,6 @@ lower_surface_logical_send(const fs_builder &bld, elk_fs_inst *inst) inst->header_size = header_sz; inst->send_has_side_effects = has_side_effects; inst->send_is_volatile = !has_side_effects; - inst->send_ex_bso = surface_handle.file != BAD_FILE && - compiler->extended_bindless_surface_offset; /* Set up SFID and descriptors */ inst->sfid = sfid;