fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 11:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

asahi: Use 2D array staging resources for cube/3D

Browse source 
Staging resources need to be linear for efficient CPU side mapping. This is a
problem for access to 3D and cube textures, since we don't have linear 3D
textures or linear cube textures. But we do have linear 2D array textures, which
can be reshaped to the same effect. So use a 2D array staging resource even for
3D textures and cube maps.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22891>
This commit is contained in:
Alyssa Rosenzweig 2023-04-09 14:16:53 -04:00
parent c11c40eaf4
commit 9f39bbdee9
1 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/gallium/drivers/asahi/agx_pipe.c
View file

@ -773,19 +773,25 @@ agx_alloc_staging(struct pipe_screen *screen, struct agx_resource *rsc,
tmpl.width0 = box->width;
tmpl.height0 = box->height;
tmpl.depth0 = 1;
/* for array textures, box->depth is the array_size, otherwise for 3d
* textures, it is the depth.
/* We need a linear staging resource. We have linear 2D arrays, but not
* linear 3D or cube textures. So switch to 2D arrays if needed.
*/
if (tmpl.array_size > 1) {
if (tmpl.target == PIPE_TEXTURE_CUBE)
tmpl.target = PIPE_TEXTURE_2D_ARRAY;
switch (tmpl.target) {
case PIPE_TEXTURE_2D_ARRAY:
case PIPE_TEXTURE_CUBE:
case PIPE_TEXTURE_CUBE_ARRAY:
case PIPE_TEXTURE_3D:
tmpl.target = PIPE_TEXTURE_2D_ARRAY;
tmpl.array_size = box->depth;
tmpl.depth0 = 1;
} else {
tmpl.array_size = 1;
tmpl.depth0 = box->depth;
break;
default:
assert(tmpl.array_size == 1);
assert(box->depth == 1);
break;
}
tmpl.last_level = 0;
tmpl.bind |= PIPE_BIND_LINEAR;