From 9f049032be400f0012f82f05cdbc2e01773838ab Mon Sep 17 00:00:00 2001 From: Lars-Ivar Hesselberg Simonsen Date: Thu, 16 Apr 2026 14:05:36 +0200 Subject: [PATCH] pan/genxml: Print shader hex in trace for Valhall Enable verbose disassembly for Valhall in traces, which adds hex values to shader printing. Useful for debugging. For example: Shader 0xffffbe3ec000 (GPU VA ffdd3000) sz 16384 LD_ATTR_IMM.v4.f32.slot0.wait0 @r0:r1:r2:r3, r60^, r61^, index:0x0, table:0x0 FRCP.f32 r3, r3^ FMAX.f32 r3, r3^, u6 vs Shader 0xffffa8bf7000 (GPU VA ffdd3000) sz 16384 7c 7d 00 32 08 80 66 08 LD_ATTR_IMM.v4.f32.slot0.wait0 @r0:r1:r2:r3, r60^, r61^, index:0x0, table:0x0 43 00 00 00 00 c3 9c 00 FRCP.f32 r3, r3^ 43 86 03 00 00 c3 a4 00 FMAX.f32 r3, r3^, u6 Reviewed-by: Christoph Pillmayer Reviewed-by: Eric R. Smith Part-of: --- src/panfrost/genxml/decode_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/genxml/decode_common.c b/src/panfrost/genxml/decode_common.c index c0e816eebf2..208d28a8cb5 100644 --- a/src/panfrost/genxml/decode_common.c +++ b/src/panfrost/genxml/decode_common.c @@ -493,7 +493,7 @@ pandecode_shader_disassemble(struct pandecode_context *ctx, uint64_t shader_ptr, pandecode_log_cont(ctx, "\nShader %p (GPU VA %" PRIx64 ") sz %" PRId64 "\n", code, shader_ptr, sz); - bool verbose = pan_arch(gpu_id) >= 6 && pan_arch(gpu_id) < 9; + bool verbose = pan_arch(gpu_id) >= 6; pan_disassemble(ctx->dump_stream, code, sz, gpu_id, verbose); pandecode_log_cont(ctx, "\n\n");