fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 05:08:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

mesa: clear program info when updating program string

Browse source 
The program info contains all sorts of flags concerning the compilation state of
the program, and those need to be reset when the program is going to be recompiled
when its source changes.

For example, before this change, after info.flrp_lowered got set following the
first call to glProgramStringARB, flrp lowering would not happen for any subsequent
updates to the program string, leading to compilation failures.

Signed-off-by: Charlotte Pabst <cpabst@codeweavers.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35523>
(cherry picked from commit be6b49449c)
This commit is contained in:
Charlotte Pabst 2025-06-13 23:09:55 +02:00 • committed by Eric Engestrom
parent 209363fd10
commit 9edbab562e
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -8094,7 +8094,7 @@
"description": "mesa: clear program info when updating program string",
"nominated": false,
"nomination_type": 0,
"resolution": 4,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

8
src/mesa/main/arbprogram.c
View file

@ -379,6 +379,14 @@ set_program_string(struct gl_program *prog, GLenum target, GLenum format, GLsize
return;
}
/* clear info */
shader_info new_info = { 0 };
new_info.name = prog->info.name;
new_info.label = prog->info.label;
new_info.stage = prog->info.stage;
new_info.use_legacy_math_rules = prog->info.use_legacy_math_rules;
prog->info = new_info;
#ifdef ENABLE_SHADER_CACHE
GLcharARB *replacement;