From 9e446c9282319de961c10d67f859fa9ac37e3ac4 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Sat, 19 Feb 2022 01:38:56 -0800 Subject: [PATCH] intel/fs/xe2+: Add comment reminding us to take advantage of the 32 SBID tokens. The additional SBID tokens will be useful when large GRF mode is implemented. Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/compiler/brw_fs_scoreboard.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs_scoreboard.cpp b/src/intel/compiler/brw_fs_scoreboard.cpp index 24183570da7..c287fd62a5c 100644 --- a/src/intel/compiler/brw_fs_scoreboard.cpp +++ b/src/intel/compiler/brw_fs_scoreboard.cpp @@ -1227,7 +1227,10 @@ namespace { { /* XXX - Use bin-packing algorithm to assign hardware SBIDs optimally in * shaders with a large number of SEND messages. + * + * XXX - Use 32 SBIDs on Xe2+ while in large GRF mode. */ + const unsigned num_sbids = 16; /* Allocate an unordered dependency ID to hardware SBID translation * table with as many entries as instructions there are in the shader, @@ -1246,7 +1249,7 @@ namespace { const dependency &dep = deps0[ip][i]; if (dep.unordered && ids[dep.id] == ~0u) - ids[dep.id] = (next_id++) & 0xf; + ids[dep.id] = (next_id++) & (num_sbids - 1); add_dependency(ids, deps1[ip], dep); }